fix: numeric fields exporting as null in parquet export - #708
Merged
najuna-brian merged 1 commit intoJul 31, 2026
Merged
Conversation
najuna-brian
changed the title
casts to double precision instead of numeric, since lib/pq doesn't decode numeric and was returning raw bytes, which failed the float64 type assertion and got silently nulled. fixes OpenDataEnsemble#707
najuna-brian
force-pushed
the
fix/numeric-export-null
branch
from
July 30, 2026 21:16
e18210d to
57e0875
Compare
najuna-brian
marked this pull request as ready for review
July 30, 2026 21:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #707. Numeric fields were casting to
::numericin the export query, but lib/pq doesn't decode that type, so it came back as raw bytes and silently failed thefloat64assertion in the parquet builder. Switched the cast todouble precision, which lib/pq decodes asfloat64directly.